Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adds staticcheck lint check #65

Merged
merged 1 commit into from
Jan 5, 2024
Merged

chore: Adds staticcheck lint check #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ linters:
- gofmt
- govet
- errcheck
# - staticcheck
- staticcheck
- unused
# - gosimple
# - ineffassign
Expand Down
4 changes: 2 additions & 2 deletions factory/factory.go
View file
Open in desktop
gab-arrobo marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ package factory

import (
"fmt"
"io/ioutil"
"os"

"github.com/omec-project/udm/logger"
"gopkg.in/yaml.v2"
Expand All @@ -21,7 +21,7 @@ var UdmConfig Config

// TODO: Support configuration update from REST api
func InitConfigFactory(f string) error {
if content, err := ioutil.ReadFile(f); err != nil {
if content, err := os.ReadFile(f); err != nil {
return err
} else {
UdmConfig = Config{}
Expand Down
9 changes: 3 additions & 6 deletions producer/generate_auth_data.go
View file
Open in desktop
gab-arrobo marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,13 @@ package producer

import (
"context"
cryptoRand "crypto/rand"
"crypto/rand"
"encoding/hex"
"fmt"
"math/big"
"math/rand"
"net/http"
"reflect"
"strings"
"time"

"github.com/antihax/optional"
"github.com/omec-project/UeauCommon"
Expand Down Expand Up @@ -163,7 +161,6 @@ func GenerateAuthDataProcedure(authInfoRequest models.AuthenticationInfoRequest,
logger.UeauLog.Traceln("In GenerateAuthDataProcedure")

response = &models.AuthenticationInfoResult{}
rand.Seed(time.Now().UnixNano())
supi, err := suci.ToSupi(supiOrSuci, udm_context.UDM_Self().GetUdmProfileAHNPrivateKey())
if err != nil {
problemDetails = &models.ProblemDetails{
Expand Down Expand Up @@ -327,7 +324,7 @@ func GenerateAuthDataProcedure(authInfoRequest models.AuthenticationInfoRequest,
// fmt.Printf("K=%x\nsqn=%x\nOP=%x\nOPC=%x\n", K, sqn, OP, OPC)

RAND := make([]byte, 16)
_, err = cryptoRand.Read(RAND)
_, err = rand.Read(RAND)
if err != nil {
problemDetails = &models.ProblemDetails{
Status: http.StatusForbidden,
Expand Down Expand Up @@ -386,7 +383,7 @@ func GenerateAuthDataProcedure(authInfoRequest models.AuthenticationInfoRequest,

SQNms, macS := aucSQN(opc, k, Auts, randHex)
if reflect.DeepEqual(macS, Auts[6:]) {
_, err = cryptoRand.Read(RAND)
_, err = rand.Read(RAND)
if err != nil {
problemDetails = &models.ProblemDetails{
Status: http.StatusForbidden,
Expand Down
6 changes: 6 additions & 0 deletions service/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,10 +409,16 @@ func (udm *UDM) UpdateNF() {
problemDetails.Status == 404 || problemDetails.Status == 400 {
// register with NRF full profile
nfProfile, err = udm.BuildAndSendRegisterNFInstance()
if err != nil {
initLog.Errorf("UDM update to NRF Error[%s]", err.Error())
}
}
} else if err != nil {
initLog.Errorf("UDM update to NRF Error[%s]", err.Error())
nfProfile, err = udm.BuildAndSendRegisterNFInstance()
if err != nil {
initLog.Errorf("UDM update to NRF Error[%s]", err.Error())
}
}

if nfProfile.HeartBeatTimer != 0 {
Expand Down