chore: Simplifies CI workflow #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
ok to test |
gab-arrobo
requested changes
Dec 11, 2023
Co-authored-by: gab-arrobo <gabriel.arrobo@intel.com>
gab-arrobo
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the Github Actions CI workflow by combining all jobs that should be run on master and on PR's to master in one file. The only real change in behavior is that we no longer update an existing PR with the outcome of a
go fmt. Since we run go lint, the CI will simply fail if a given PR has bad formatting.Effectively, this reduces the amount of CI lines of code by more than 50% without sacrificing anything.
Rationale
It was hard to wrap one's head around what jobs were done at which moment because of the various files, their different conditions and the amount of commented workflow line. While the file representation was hard to read, the actual workflow was quite simple: Run X, Y, Z jobs on push to master and PR's to master. This PR here reflects this.