Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable NRF response caching #135

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Aug 23, 2024

Implementing NRF response caching together with NF subscribe and notify services

Implementing NRF response caching together with NF subscribe and notify services

Signed-off-by: gatici <gulsum.atici@canonical.com>
Signed-off-by: gatici <gulsum.atici@canonical.com>
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. I added a few comments (some of them can be addressed in another PR).

consumer/nf_discovery.go Outdated Show resolved Hide resolved
consumer/nf_management.go Outdated Show resolved Hide resolved
factory/config.go Outdated Show resolved Hide resolved
service/init.go Outdated Show resolved Hide resolved
udmtests/udm_nf_discovery_test.go Outdated Show resolved Hide resolved
…ables definition

Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici requested a review from gab-arrobo August 26, 2024 09:09
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (tested changes with OnRamp)

@gab-arrobo gab-arrobo merged commit 88db149 into omec-project:master Aug 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants