chore: Adds staticcheck lint check (#65)

.golangci.yml

@@ -221,7 +221,7 @@ linters:
     - gofmt
     - govet
     - errcheck
-    # - staticcheck
+    - staticcheck
     - unused
     # - gosimple
     # - ineffassign

factory/factory.go

@@ -11,7 +11,7 @@ package factory
 
 import (
 	"fmt"
-	"io/ioutil"
+	"os"
 
 	"github.com/omec-project/udm/logger"
 	"gopkg.in/yaml.v2"
@@ -21,7 +21,7 @@ var UdmConfig Config
 
 // TODO: Support configuration update from REST api
 func InitConfigFactory(f string) error {
-	if content, err := ioutil.ReadFile(f); err != nil {
+	if content, err := os.ReadFile(f); err != nil {
 		return err
 	} else {
 		UdmConfig = Config{}

producer/generate_auth_data.go

@@ -7,15 +7,13 @@ package producer
 
 import (
 	"context"
-	cryptoRand "crypto/rand"
+	"crypto/rand"
 	"encoding/hex"
 	"fmt"
 	"math/big"
-	"math/rand"
 	"net/http"
 	"reflect"
 	"strings"
-	"time"
 
 	"github.com/antihax/optional"
 	"github.com/omec-project/UeauCommon"
@@ -163,7 +161,6 @@ func GenerateAuthDataProcedure(authInfoRequest models.AuthenticationInfoRequest,
 	logger.UeauLog.Traceln("In GenerateAuthDataProcedure")
 
 	response = &models.AuthenticationInfoResult{}
-	rand.Seed(time.Now().UnixNano())
 	supi, err := suci.ToSupi(supiOrSuci, udm_context.UDM_Self().GetUdmProfileAHNPrivateKey())
 	if err != nil {
 		problemDetails = &models.ProblemDetails{
@@ -327,7 +324,7 @@ func GenerateAuthDataProcedure(authInfoRequest models.AuthenticationInfoRequest,
 	// fmt.Printf("K=%x\nsqn=%x\nOP=%x\nOPC=%x\n", K, sqn, OP, OPC)
 
 	RAND := make([]byte, 16)
-	_, err = cryptoRand.Read(RAND)
+	_, err = rand.Read(RAND)
 	if err != nil {
 		problemDetails = &models.ProblemDetails{
 			Status: http.StatusForbidden,
@@ -386,7 +383,7 @@ func GenerateAuthDataProcedure(authInfoRequest models.AuthenticationInfoRequest,
 
 		SQNms, macS := aucSQN(opc, k, Auts, randHex)
 		if reflect.DeepEqual(macS, Auts[6:]) {
-			_, err = cryptoRand.Read(RAND)
+			_, err = rand.Read(RAND)
 			if err != nil {
 				problemDetails = &models.ProblemDetails{
 					Status: http.StatusForbidden,

service/init.go

@@ -409,10 +409,16 @@ func (udm *UDM) UpdateNF() {
 			problemDetails.Status == 404 || problemDetails.Status == 400 {
 			// register with NRF full profile
 			nfProfile, err = udm.BuildAndSendRegisterNFInstance()
+			if err != nil {
+				initLog.Errorf("UDM update to NRF Error[%s]", err.Error())
+			}
 		}
 	} else if err != nil {
 		initLog.Errorf("UDM update to NRF Error[%s]", err.Error())
 		nfProfile, err = udm.BuildAndSendRegisterNFInstance()
+		if err != nil {
+			initLog.Errorf("UDM update to NRF Error[%s]", err.Error())
+		}
 	}
 
 	if nfProfile.HeartBeatTimer != 0 {