add subscriber support to simapp #7
Conversation
config/simapp.yaml
Outdated
| @@ -11,6 +11,17 @@ configuration: | |||
| APP: | |||
| ReportCaller: false | |||
| debugLevel: info | |||
| subscribers: | |||
| - ueId: 123456789123456 | |||
There was a problem hiding this comment.
take range based argument as well. so we can configure more subscribers in one shot
| @@ -11,6 +11,17 @@ configuration: | |||
| APP: | |||
| ReportCaller: false | |||
| debugLevel: info | |||
| subscribers: | |||
There was a problem hiding this comment.
we should have range based + single subscriber both options
There was a problem hiding this comment.
Done, already put the one subscriber and a range based subscriber in yaml.
| @@ -11,6 +11,17 @@ configuration: | |||
| APP: | |||
| ReportCaller: false | |||
| debugLevel: info | |||
| subscribers: | |||
There was a problem hiding this comment.
add final config in helm chart as well.
simapp.go
Outdated
| @@ -247,6 +283,8 @@ func sendMessage(msgChan chan configMessage) { | |||
| fmt.Println("device trigger http endpoint ", devGroupHttpend) | |||
| networkSliceHttpend = "http://" + ip.String() + ":9089/config/v1/network-slice/" | |||
| fmt.Println("network slice http endpoint ", devGroupHttpend) | |||
| subscriberHttpend = "http://127.0.0.7" + ip.String() + ":5000/api/" | |||
There was a problem hiding this comment.
We want to pass subscriber provisioning APIs through ROC. IF ROC does not exist then pass the APIs to webui. Take the destination URI as argument from the helmchart. So code remains clean
There was a problem hiding this comment.
helm chart + this comment will be pushed in another patch later. You can review the new patch now.
simapp.go
Outdated
| @@ -104,6 +116,7 @@ type AppInfo struct { | |||
| const ( | |||
| device_group = iota | |||
| network_slice | |||
| SUBSCRIBER | |||
There was a problem hiding this comment.
can we keep name in the the same format like other 2 enums ? all lower case ?
simapp.go
Outdated
| @@ -49,6 +51,16 @@ type IpDomain struct { | |||
| UePool string `yaml:"ue-ip-pool,omitempty" json:"ue-ip-pool,omitempty"` | |||
| } | |||
|
|
|||
| type Subscriber struct { | |||
| UeId string `yaml:"ueId,omitempty" json:"ueId,omitempty"` | |||
There was a problem hiding this comment.
We have UeIdStart, UeIdEnd and also UeId. Can you clarify when UeId is used ? I dont see any usage of UeId ?
Let me tell you again, 2 requirements
- Add single subscriber with ueid : 123456789123456
- Add multiple subscribers from ueid_start to ueid_end :; 123456789123456 to 123456789123459.
There was a problem hiding this comment.
this one format can meet 2 requirements, when the start = end, then it means just one ue.
My first version of code is like:
ueid:***
ueid_start:***
ueid_end:****
I feel not necessary, and confusing, so I improved it with removing ueid.
|
Please rebase for the |
also fixed the UE id format, which should be start with imsi- in DB
|
ghost
merged commit 
No description provided.