Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strconv.Atoi used for converting string to integer #30

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

vthiruveedula
Copy link
Contributor

to integer value

@thakurajayL
Copy link
Contributor

thakurajayL commented Jun 2, 2022

Will this changes have any impact on existing setups ?
No, It doesn't impact existing setups. We can merge.

simapp.go Outdated
@@ -726,7 +726,7 @@ func UpdateConfig(f string) error {
var msg configMessage
msg.msgPtr = reqMsgBody
msg.msgType = subscriber
msg.name = strconv.FormatUint(k, 10)
msg.name = strconv.FormatUint(uint64(k), 10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this not remove the 0's at the start of IMSI ? Can you check if message sent towards Webconsole has right URL. msg.name is used to " httpend = subscriberHttpend + msg.name"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete might not work.. let me check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ajay. Delete didn't work. Fixed it and pushed changes. Add /delete of subscribers worked with latest

@thakurajayL thakurajayL merged commit 9545c5e into main Jun 3, 2022
@thakurajayL thakurajayL deleted the dev-imsi-issue branch June 3, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants