Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix short SHA tag when publishing docker images #58

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Fix short SHA tag when publishing docker images #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@ jobs:
uses: actions/checkout@v2

- name: Read version file
id: get_version
uses: andstor/file-reader-action@v1
with:
path: ./VERSION
run: echo VERSION=$(cat ./VERSION) >> $GITHUB_ENV

- name: Build protobuf
id: check
Expand All @@ -48,8 +45,7 @@ jobs:
password: ${{ secrets.DOCKER_PASSWORD }}

- name: Get short SHA
id: short_sha
run: echo "::set-output name=sha8::$(echo ${GITHUB_SHA} | cut -c1-8)"
run: echo GIT_SHA_SHORT=$(git rev-parse --short HEAD) >> $GITHUB_ENV

- name: Build with Docker
uses: docker/build-push-action@v2
Expand All @@ -58,9 +54,9 @@ jobs:
push: false
load: true
tags: |
${{ env.DOCKER_REPO }}:${{ steps.get_version.outputs.contents }}
${{ env.DOCKER_REPO }}:${{ env.VERSION }}
${{ env.DOCKER_REPO }}:latest
${{ env.DOCKER_REPO }}:${{ steps.short_sha.outputs.sha8 }}
${{ env.DOCKER_REPO }}:${{ env.GIT_SHA_SHORT }}
target: 'pfcpsim'

- name: Test docker build
Expand All @@ -75,7 +71,7 @@ jobs:
# build on feature branches, push only on main branch
push: ${{ github.ref == 'refs/heads/main' }}
tags: |
${{ env.DOCKER_REPO }}:${{ steps.get_version.outputs.contents }}
${{ env.DOCKER_REPO }}:${{ env.VERSION }}
${{ env.DOCKER_REPO }}:latest
${{ env.DOCKER_REPO }}:${{ steps.short_sha.outputs.sha8 }}
${{ env.DOCKER_REPO }}:${{ env.GIT_SHA_SHORT }}
target: 'pfcpsim'