feat: add PCF metrics counters #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dario Faccin <dario.faccin@canonical.com>
Signed-off-by: Dario Faccin <dario.faccin@canonical.com>
gatici
approved these changes
Oct 2, 2024
thakurajayL
requested changes
Oct 5, 2024
producer/smpolicy.go
Outdated
| @@ -255,11 +259,18 @@ func createSMPolicyProcedure(request models.SmPolicyContextData) ( | |||
| func HandleDeleteSmPolicyContextRequest(request *httpwrapper.Request) *httpwrapper.Response { | |||
| logger.SMpolicylog.Infoln("handle DeleteSmPolicyContext") | |||
| smPolicyID := request.Params["smPolicyId"] | |||
| response, problems := getSmPolicyContextProcedure(smPolicyID) | |||
| smPolicyDnn := "UNKNOWN_DNN" | |||
| if problems != nil { | |||
There was a problem hiding this comment.
Should it be response != nil ?
if problem is not nil then response is nil and it would lead to crash.
producer/smpolicy.go
Outdated
| // status code is based on SPEC, and option headers | ||
| return httpwrapper.NewResponse(http.StatusOK, nil, response) | ||
| } else if problemDetails != nil { | ||
| stats.IncrementPcfSmPolicyStats("get", "UNKNOWN_DNN", "SUCCESS") |
There was a problem hiding this comment.
Should not this be FAILURE?
producer/smpolicy.go
Outdated
| @@ -340,17 +354,25 @@ func HandleUpdateSmPolicyContextRequest(request *httpwrapper.Request) *httpwrapp | |||
| logger.SMpolicylog.Infoln("handle UpdateSmPolicyContext") | |||
| requestDataType := request.Body.(models.SmPolicyUpdateContextData) | |||
| smPolicyID := request.Params["smPolicyId"] | |||
| getResponse, getProblemDetails := getSmPolicyContextProcedure(smPolicyID) | |||
| smPolicyDnn := "UNKNOWN_DNN" | |||
| if getProblemDetails != nil { | |||
There was a problem hiding this comment.
- getResponse would be nil if getProblemDetails is not nil.
- Can we have consistency in naming these variables?
Signed-off-by: Dario Faccin <dario.faccin@canonical.com>
Signed-off-by: Dario Faccin <dario.faccin@canonical.com>
thakurajayL
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new 5G specific metrics,
pcf_smpolicyandpcf_policy_authorizationto exported metrics via Prometheus.The scope of the metrics is the following:
pcf_smpolicy: this metric counts the total number of Session Management policy queries to PCF; the metric stores the query type (create,get,update,delete), the DNN and the result (SUCCESS,FAILURE);pcf_policy_authorization: this metric counts the total number policy authorization queries to PCF; the metric stores the query type (create,get,update,delete), the resource type (application_sessions,events_subscriptions) and the result (SUCCESS,FAILURE).