Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace logrus with zap logger #13

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Replace logrus with zap logger #13

merged 4 commits into from
Sep 29, 2024

Conversation

gab-arrobo
Copy link
Contributor

@gab-arrobo gab-arrobo commented Sep 28, 2024 •
edited
Loading

This PR includes the following:

  1. Replace login library logrus with zap logger
  2. Use latest version for dependencies (aper and openapi) that already use zap logger instead of logrus
  3. Create a minor release

Changes were tested with OnRamp using the replace directive for the smf image/pod

@gab-arrobo
Replace logrus with zap
5e44697 
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@gab-arrobo gab-arrobo marked this pull request as draft September 28, 2024 19:05
@gab-arrobo
Use latest version for aper and openapi dependencies
10345aa 
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@gab-arrobo
Improve logger by disabling the stacktrace
32e5e07 
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@gab-arrobo
Create minor release
ce42cda 
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@gab-arrobo gab-arrobo marked this pull request as ready for review September 29, 2024 02:45
@gab-arrobo gab-arrobo merged commit 99fdea3 into omec-project:main Sep 29, 2024
6 checks passed
@gab-arrobo gab-arrobo deleted the zap-logger branch September 29, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaythakurintel ajaythakurintel ajaythakurintel left review comments

@thakurajayL thakurajayL thakurajayL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gab-arrobo @thakurajayL @ajaythakurintel