Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add GitHub Action workflows and dependabot configuration #11

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

ghislainbourgeois
Copy link
Contributor

No description provided.

@onf-bot
Copy link
Contributor

onf-bot commented Jan 23, 2024

Can one of the admins verify this patch?

1 similar comment
@onf-bot
Copy link
Contributor

onf-bot commented Jan 23, 2024

Can one of the admins verify this patch?

Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gab-arrobo gab-arrobo merged commit 1abb3b0 into omec-project:master Jan 23, 2024
1 check passed
@gab-arrobo
Copy link
Contributor

gab-arrobo commented Jan 23, 2024

@ghislainbourgeois, another PR is needed to address the lint issues (basically apply gofmt to security/counter.go and nasConvert/UPUInfo.go). Moreover, remove a few deprecated lints.

@gab-arrobo
Copy link
Contributor

@ghislainbourgeois, another PR is needed to address the lint issues (basically apply gofmt to security/counter.go and nasConvert/UPUInfo.go). Moreover, remove a few deprecated lints.

FYI, PR #15 will address the lint issues.

@ghislainbourgeois ghislainbourgeois deleted the add-workflows branch January 23, 2024 20:41
@gab-arrobo
Copy link
Contributor

@ghislainbourgeois, another PR is needed to address the lint issues (basically apply gofmt to security/counter.go and nasConvert/UPUInfo.go). Moreover, remove a few deprecated lints.

@ghislainbourgeois, another thing we need to do in this repo is to upgrade the GO version for the module. Current version is 1.14 and, I think, we should move to 1.21 as we have is most of the other SD-Core repos

@gab-arrobo
Copy link
Contributor

@ghislainbourgeois, another PR is needed to address the lint issues (basically apply gofmt to security/counter.go and nasConvert/UPUInfo.go). Moreover, remove a few deprecated lints.

@ghislainbourgeois, another thing we need to do in this repo is to upgrade the GO version for the module. Current version is 1.14 and, I think, we should move to 1.21 as we have is most of the other SD-Core repos

I just opened PR #16 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants