Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: divide subscribeToConfigPod method to manage GRPC server connection separately inside the modules #69

Merged
merged 7 commits into from
Oct 17, 2024
Merged

refactor: divide subscribeToConfigPod method to manage GRPC server connection separately inside the modules #69

merged 7 commits into from
Oct 17, 2024

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Oct 2, 2024

The aim of this change is managing the GRPC server connection separately inside the modules.
This PR refactors ConfClient interface methods which is used to subscribe to Config pod NMS.
refactor:

  • add ConnectToGrpcServer method to ConfClient interface
  • change signatures of PublishOnConfigChange and subsribeToConfigPod methods

After getting updated this library, the necessary changes will be done in every module to solve the GRPC client re-connection issue.
These changes are done to solve the following problem:

If the Webconsole is restarted, other modules loses the GRPC connection to Webconsole
They tries to connect again for hours with no success.

2024-09-26T11:32:10.014Z [smf] 2024-09-26T11:32:10Z [ERRO][Config5g][GRPC] Connectivity status idle, trying to connect again.

Please check the implementation in NF side: omec-project/nrf#132

@thakurajayL
Copy link
Contributor

Could you please suggest one example how NFs are going to use these updated APIs? This will help in doing effective code review.

proto/client/gClient.go Show resolved Hide resolved
proto/client/gClient.go Show resolved Hide resolved
@gatici
Copy link
Contributor Author

gatici commented Oct 7, 2024

Could you please suggest one example how NFs are going to use these updated APIs? This will help in doing effective code review.

Hello @thakurajayL ,
This PR shows how to use updated config5G library: omec-project/nrf#132

@gatici gatici requested a review from thakurajayL October 8, 2024 09:45
proto/client/gClient.go Outdated Show resolved Hide resolved
proto/client/gClient.go Outdated Show resolved Hide resolved
proto/client/gClient.go Outdated Show resolved Hide resolved
proto/client/gClient.go Show resolved Hide resolved
proto/client/gClient.go Outdated Show resolved Hide resolved
proto/client/gClient.go Outdated Show resolved Hide resolved
proto/client/gClient.go Outdated Show resolved Hide resolved
proto/client/gClient.go Outdated Show resolved Hide resolved
@gatici gatici requested a review from gab-arrobo October 15, 2024 17:23
@gab-arrobo
Copy link
Contributor

@gatici, please rebase your PR and also, I understand that you/we need to create a new tag/release for the NFs to start using these changes. If so, please also make the appropriate change in the VERSION file to create a release (major, minor or patch, as you deem appropriate) as part of this PR, ok?

…nnection separately through the modules

refactor:
- add ConnectToGrpcServer method to ConfClient interface
- change signatures of PublishOnConfigChange and subsribeToConfigPod methods

Signed-off-by: gatici <gulsum.atici@canonical.com>
ConfigWather method is not necessary anymore as all the NFs will call PublishOnConfigChange

Signed-off-by: gatici <gulsum.atici@canonical.com>
Signed-off-by: gatici <gulsum.atici@canonical.com>
Signed-off-by: gatici <gulsum.atici@canonical.com>
Signed-off-by: gatici <gulsum.atici@canonical.com>
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici
Copy link
Contributor Author

gatici commented Oct 15, 2024

@gatici, please rebase your PR and also, I understand that you/we need to create a new tag/release for the NFs to start using these changes. If so, please also make the appropriate change in the VERSION file to create a release (major, minor or patch, as you deem appropriate) as part of this PR, ok?

@thakurajayL @gab-arrobo PR is rebased and version file is updated.

proto/client/gClient.go Outdated Show resolved Hide resolved
proto/client/gClient.go Outdated Show resolved Hide resolved
proto/client/gClient.go Outdated Show resolved Hide resolved
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici requested a review from gab-arrobo October 17, 2024 22:31
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gab-arrobo gab-arrobo merged commit 4eee5b2 into omec-project:main Oct 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants