-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: divide subscribeToConfigPod method to manage GRPC server connection separately inside the modules #69
refactor: divide subscribeToConfigPod method to manage GRPC server connection separately inside the modules #69
Conversation
Could you please suggest one example how NFs are going to use these updated APIs? This will help in doing effective code review. |
Hello @thakurajayL , |
@gatici, please rebase your PR and also, I understand that you/we need to create a new tag/release for the NFs to start using these changes. If so, please also make the appropriate change in the |
…nnection separately through the modules refactor: - add ConnectToGrpcServer method to ConfClient interface - change signatures of PublishOnConfigChange and subsribeToConfigPod methods Signed-off-by: gatici <gulsum.atici@canonical.com>
ConfigWather method is not necessary anymore as all the NFs will call PublishOnConfigChange Signed-off-by: gatici <gulsum.atici@canonical.com>
Signed-off-by: gatici <gulsum.atici@canonical.com>
Signed-off-by: gatici <gulsum.atici@canonical.com>
Signed-off-by: gatici <gulsum.atici@canonical.com>
Signed-off-by: gatici <gulsum.atici@canonical.com>
@thakurajayL @gab-arrobo PR is rebased and version file is updated. |
Signed-off-by: gatici <gulsum.atici@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The aim of this change is managing the GRPC server connection separately inside the modules.
This PR refactors ConfClient interface methods which is used to subscribe to Config pod NMS.
refactor:
After getting updated this library, the necessary changes will be done in every module to solve the GRPC client re-connection issue.
These changes are done to solve the following problem:
Please check the implementation in NF side: omec-project/nrf#132