Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adding webUri input parameter to ConfigWatcher function #35

Merged
merged 2 commits into from
Mar 25, 2024
Merged

chore: Adding webUri input parameter to ConfigWatcher function #35

merged 2 commits into from
Mar 25, 2024

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Mar 25, 2024 •
edited
Loading

  • Adding webUri input parameter to ConfigWatcher function to parameterise Webui URL.
  • Adding golangci.yml for linting checks
  • Adding GHA for linting

This was referenced Mar 25, 2024
Merged
Merged
Merged
Merged
Merged
gab-arrobo
gab-arrobo reviewed Mar 25, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
gab-arrobo
gab-arrobo reviewed Mar 25, 2024
View reviewed changes
.golangci.yml Show resolved Hide resolved
go/config.pb.go Outdated Show resolved Hide resolved
gatici and others added 2 commits March 25, 2024 21:29
@gatici
Adding webUri input parameter to ConfigWatcher function
da73779 
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gab-arrobo
Fix lint issue
d8e12c3
gab-arrobo
gab-arrobo approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (tested changes with OnRamp using replace directive for the ausf image

@gab-arrobo gab-arrobo merged commit 7cbe8f4 into omec-project:main Mar 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gab-arrobo gab-arrobo gab-arrobo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gatici @gab-arrobo