fix: Fix 100% CPU usage when webui is not available or not configured #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gab-arrobo
previously approved these changes
Feb 16, 2024
proto/client/gClient.go
Outdated
| @@ -172,9 +172,11 @@ func (confClient *ConfigClient) subscribeToConfigPod(commChan chan *protos.Netwo | |||
| } | |||
| } else if status == connectivity.Idle { | |||
| logger.GrpcLog.Errorf("Connectivity status idle, trying to connect again") | |||
| time.Sleep(time.Second * 5) | |||
| continue | |||
| } else { | |||
| //logger.GrpcLog.Errorf("Connectivity status not ready") | |||
There was a problem hiding this comment.
Should this line be re-enabled? It may help for debugging
There was a problem hiding this comment.
Agreed, I added it back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying SDCore, all services using this client code go into a tight loop using 100% of a CPU thread until webui is available and configured with a network slice.
This change adds some small sleeps that will free up some CPU time. The worst case scenario with this sleep is that the service will take 5 seconds more to get configured after initial deployment.
The PR also bumps
logger_confto the latest version, to prevent pulling inomec-project/path_util.