extend CLI admin email timeout #5608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See |
|
Ah, so close this PR and add |
|
Keeping this as a bump of the default timeout makes sense, too. |
mtbc
force-pushed
the
extend-email-timeout
branch
from
b29e43f to
63595a5
Compare
|
Looks good, works like expected. Good to merge 👍 |
|
@kennethgillen : If there's anywhere in particular you think this should be advertised, please let us know. |
|
It should probably be an example somewhere on https://docs.openmicroscopy.org/latest/omero/sysadmins/index.html I missed this myself. Might have been worth a "sysadmin update" in the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Sending e-mail to a user of our demo server takes around 15s. This PR extends the timeout for
bin/omero admin email ...so as to be more patient with such slow servers.Testing this PR
Use the CLI to send e-mail to a demo server user and check that the e-mail is received and
omero::LockTimeoutis not thrown at you. (I ammtbcarrollon that server and I am happy to make anyone else an account on it.) Can also try out the--waitoption.Related reading
https://trello.com/c/bSyOy8Bh/34-cli-or-email-plugin-5s-timeout