Post merge #5243
Merged
Post merge #5243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@jburel do you see any more name changes/fixes in m53? |
|
Changes all make sense. Are the tests currently being run somewhere? |
|
@aleksandra-tarkowska sorry I missed the notification. I will have a look |
|
Thanks, @aleksandra-tarkowska. From my point-of-view, this is good to merge. |
jburel
reviewed
Apr 19, 2017
| plateCols=colCount)[0] | ||
| plate2 = self.test.importPlates(plateRows=rowCount, | ||
| plateCols=colCount)[0] | ||
| plate1 = self.test.import_plates(plateRows=rowCount, |
There was a problem hiding this comment.
This should be plate_rows and plate_cols if the method from testlib is used
|
@jburel thanks for the hint, looks like all metadata tests are passing now :) |
|
It looks good now |
|
cherry-picked fix from #5241 for py26 (just for consistency) |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
fix failing tests
cherry-picked to #5241