Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup command for testing external apps #22

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ recommended to use
where NAME is `app`, `cli`, `lib` or `scripts`. The special `srv`
command will build the parent directory as a replacement for the
OMERO.server container.
The `setup` command can be used to setup a server for testing external applications using your own scripts.
For example, run `NOCLEAN=true OMERO_SERVER_SSL=4064: .omero/docker setup` and connect to `localhost:4064`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd include the NOCLEAN=true in the the stage itself.


It is also possible to combine several application e.g.

Expand Down
10 changes: 10 additions & 0 deletions docker
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,16 @@ for STAGE in $STAGES; do
run py common
run --user scripts build
;;
setup)
export COMPONENT=server
export USER=omero-server
export CID="$PROJECT"_omero_1
export OMERO_DIST="/opt/omero/server/OMERO.server"
start_up
install
wait_on_login
run --user omero init
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really match the rest of the naming structure. Moving this discussion to the review comment, but if srv is the testing of ../Dockerfile I'd be interested in a prefix other than omero-* that could represent this stage.

;;
srv)
export COMPONENT=server
export USER=omero-server
Expand Down
2 changes: 2 additions & 0 deletions omero-init
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#!/bin/bash
echo "No initialisation required"