-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch export ROI coordinates #147
Conversation
40b6eef
to
3a87f40
Compare
3a87f40
to
bc373d9
Compare
The resulting csv is still named "roi-intensities". Maybe "Batch ROI export" ? |
comparing an ellipse area between
I see two things
user-3 On the other hand, line and polyline shows a bit different behaviour (than the ellipse described above) - all differences can be explained by rounding errors. |
user-3 http://web-dev-merge.openmicroscopy.org/webclient/?show=image-162101 the order of ROIs in the CSV is different between iviewer and the script here. Batch ROI export is having its own ordering of ROIs, which I do not see at the moment the logic of. |
Tested up till now Calibration
Some comments made |
Those commits fix the default name of the csv to |
I think we should also revise the allocation of this script under "Export". Note: This script is not exporting ROIs. Unlike the Batch image export, which is exporting images. I think this script belongs under Analysis. |
Yes, I cannot repeat that myself now, but I guess it is good to have the ROIs sorted. |
The difference in Ellipse area between iviewer and Export script is an iviewer issue fixed in ome/omero-iviewer#263 |
I think this is still an "Export" script. Image export is different from downloading originals. It's exporting *as" png etc. Here, we are exporting ROIs as csv. Also, the script is called To test last commits:
|
Yes, understood, but these are all internal naming decisions. Camparison with other softwares shows that such functionality is always under Measure, Analyse etc. We are exporting values, measurements, coordinates. Saying that we are "exporting ROIs" is too much of a shortcut, and, more importantly, it does not ring a bell with what the user heard elsewhere IMHO |
testing on eel user-3
Ellipse:
I probably do not understand the rounding - not sure how would I round the numbers to get from the script one to the iviewer one. They seem different to me. Also, still not clear why the decimanl places after the point should be so many in the script, so little in iviewer. |
Actually, this is fine. Maybe lets better stick to the current status - more decimal places in the CSV seem a good idea to me, Excel can easily round it for you later. yes, the image shows now the same elipse size in iviewer and script #147 (comment) All good here |
Noticed during the Dundee workshop - the Batch_ROI_Export script didn't include shape coordinates, lengths or areas. This adds them to the exported CSV, similar to export from iviewer: ome/omero-iviewer#257
To test:
NB: We use the same pixel size units for the length and area of shapes from all images (since the column has a single unit in header). If some images have very different pixel size units from other images, we could get some very big or small numbers in the CSV, but we can probably assume they are similar if being exported together.
NB: The length and area are converted to length units (e.g. microns) but the shape coordinates are not. They are given in pixel coordinates, including e.g. the Rectangle Width and Height. This is the same behaviour as for iviewer ROI export. I think it makes sense and hope this will be understood by users.