-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert OMERO strings to unicode #4
Conversation
Added a test (uses modified omero-test-infra) Though looks like travis isn't enabled on this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, 👍 for dealing with unicode and 💯 for adding the tests.
Continuing the conversation from ome/omero-test-infra#22, I'm pretty sure this could be accomplished with test-data
and lib-test
files, but we can discuss that there.
Most relevant question here is if a unicode-aware unwrap
method (or something else) would have helped you here.
Also, is "Login as микроскопом-пони fails with a unicode error so create" written up somewhere?
Thanks, I've got it working with |
Closing and re-opening to trigger travis. |
and weekly cron activated. |
docker run --link $CID:omero --net $NETWORK --rm -d -p 9449:9449 --name omero-prometheus-tools test -s omero -u root -w omero -c /opt/omero-prometheus-tools/etc/prometheus-omero-counts.yml -v | ||
sleep 10 | ||
./test.py | ||
if [ "$NOCLEAN" != "true" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this should probably be in the upstream lib-test
and/or docker
script as well.
Nicely done. Shall his become 0.1.1? |
👍 for |
Fixes https://trello.com/c/lLxHorjS/5609-prom-exporter-unicodedecodeerror
OMERO rstrings may contain unicode, but they are not automatically converted to Python unicode. This solution involved some trial-and-error.
Testing:
omero-prometheus-tools.py -s pub-omero.openmicroscopy.org -u PRIVILEGED-USER -w PASSWORD -v -c etc/prometheus-omero-counts.yml
against a server that has Unicode group names e.g. pub-omero and go to http://localhost:9449/