Resize viewer when thumbnail panel hidden #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am struggling to see a difference between iviewer on merge-ci and on outreach. |
|
This time I am using Firefox and it is easier to reproduce what we discussed on the call. |
|
I did some further tests in chrome, still easier to "expose" the issue in Firefox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367
To test, open an orphaned image in iviewer (Thumbnails panel will be hidden).
The image shouldn't appear stretched length-ways.
Then make a tiny drag to resize the right-panel divider or a tiny resize of the browser window and you shouldn't notice a change in the aspect ratio of the image (as in the video attached to the image.sc post above).