Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: print to console #334

Merged
merged 1 commit into from
Aug 11, 2020
Merged

test: print to console #334

merged 1 commit into from
Aug 11, 2020

Conversation

jburel
Copy link
Member

@jburel jburel commented Aug 3, 2020

print error output to the console when running the tests.
This was useful when investigating ome/omero-plugins#42

cc @sbesson

@will-moore
Copy link
Member

Not sure how to test this but it looks reasonable.
Ran $ ant unit-tests on this branch but don't expect to see any infrastructure_error output.

sbesson
sbesson approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As karma is only used for testing purposes and this change was required for debugging the Travis issue as mentioned in the description, I think there is little impact associated with merging this anyways

@sbesson sbesson merged commit f3f4461 into ome:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbesson sbesson sbesson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jburel @will-moore @sbesson