Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow higher max zoom for Big images #325

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Jun 19, 2020

See https://forum.image.sc/t/omero-iviewer-zoom-limits/39220

This allows higher zoom levels for big images.
To test, try zooming in on a big image. Should now be able to go to 644% (instead of 161%).

Also check that max zoom of non-Big images is unchanged at 4000% (Not sure if we should reduce this?).

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omero-iviewer-zoom-limits/39220/2

@AarghIMApiratez
Copy link

Hi Will,

Thanks for the quick response and starting a pull request.

This is purely from a user perspective. But I think it makes sense to allow more zoom for a larger images That is, regardless of an image's size you end up with pixels that are of the same size on your screen.

See my two images attached (Viewed without interpolate).
The two images are imaged at the same resolution / settings etc.

Small image A. allows 4000% zoom. Where pixels are huge. (~2 times my cursor height?)
Larger image B. allows 161% zoom (now changed by you to 322%). Here I can barely make them out.

In my view a good value would be 500% (image C). 322 might do the trick, but should be the same regardless of size.

Image A
image

Image B
image

Image C
image

Mind that I havent thought about if/how resolutions on different screens might affect what is reasonable.

Friendly regards, Staffan

Copy link
Member

@mtbc mtbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zoom increased for big images, remains at 4000% for other.

@jburel jburel merged commit 299e640 into ome:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants