Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix click to select viewer #239

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Conversation

will-moore
Copy link
Member

This fixes an issue noticed by @pwalczysko at #233 (comment)

To test:

  • In multi-viewer mode, clicking on a viewer anywhere is enough to select it (don't have to click on frame).

With openlayers-3 this worked on mousedown but it seems that openlayers-5 doesn't emit
mousedown events
@will-moore will-moore changed the title Fix viewer selection with click onto image Fix click to select viewer Feb 18, 2019
@pwalczysko
Copy link
Member

this works as expected on Mac FF, Win 7 FF, IE, Mac Chrome, Win 7 Chrome.

@jburel jburel merged commit 7586ec6 into ome:master Feb 19, 2019
@jburel jburel added this to the 0.7.0 milestone Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants