-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Horizontal and Vertical Image Flipping Functionality #591
Conversation
This is working really nicely. Looking good. Small point: I have used custom padding on the It took me a while to find a couple of minor issues: The dragging to pan images is working under most conditions except if I have only 1 axis flipped AND I have a rotation of e.g. 90 degrees. This is quite tricky, and a bit edge-case so don't worry about it too much. Even more edge-case is if you select 2 images and only 1 of them is flipped, then the panning in the viewport is "wrong" for one of the images (since they appear overlaid with the same flip applied when dragging, then the same pan direction is applied to both instead of opposites). Really not worried about this one! |
The build is failing above because the export script is failing with
You'll need to use |
I see now that you've bumped the |
Hi Will,
I reverted those changes. I included them because I thought this would solve the test errors, but handling the optional properties also in python is smarter. @MinaEnayat also resolved the export to tiff and the preview panel display (the right panel preview was not flipped correctly when using the rotation slider). |
Thanks for the updates on this and other PRs. Just a heads up that I'm pretty tied up over the next week or so - Afraid I might not get time to review etc for a bit... |
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/how-to-mirror-images-on-omero-figure/105059/2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good now, thanks.
The only issue I'm seeing is when I try to pan a panel that is rotated AND flipped.
The "Known issue" in the PR description (flipping when dragging rotation slider) seems to be fixed. So perhaps you can update the description accordingly so we have that as a record.
Hey Will,
I’ve added a new function to handle image flipping, including the following updates:
Known Issue:
When the image is flipped and rotated, paning the image around behaves weirdly.
With the collaboration of @Tom-TBT
Fixes #552