-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link url to image #584
base: master
Are you sure you want to change the base?
Link url to image #584
Conversation
A few flake8 errors in the build:
NB: you should be able to use |
Hi @will-moore I fixed the flake8 errors. I finally noticed that |
You can use https://docs.djangoproject.com/en/5.1/ref/request-response/#django.http.HttpRequest.build_absolute_uri
|
Seems to be working fine from my testing so far... |
Ok cool !
I agree, it could be better I also noticed that I should remove the KVP from images when the figure is deleted, which is not yet the case. |
I think it would be better not to include the figure Name in the Key because it's tricky to handle re-naming. Everything else seems to be working fine (delete Figure removes KVP etc). |
Thanks for your feedback. |
Fixes #514 by adding a KVP on each image used a the figure. The KVP consists on the Figure URL