Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes may2024 #561

Merged
merged 2 commits into from
May 7, 2024
Merged

Bugfixes may2024 #561

merged 2 commits into from
May 7, 2024

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented May 3, 2024

Fixes for a bug introduced with the un-released vite.js upgrade at #477:

  • Channel sliders: for small ranges (e.g. float data where brightest pixel is less than 100) we use a smaller step for the slider and we format the value to float when displaying in the start/end text boxes. We also have logic to prevent the 'end' slider value going less than the 'start' slider. In this bug, I wasn't using the full pixel range to check for using small step and float formatting - therefore the test image (see fake image below) with pixel range of -32768.00 - 72 was using the float formatting etc. Also, the formatting to string step was happening before we compared start < end values, so we were comparing string with number which gave a wrong result (so that when sliding the 'end' value, it would get reset to the same as the start value.

testProjection&sizeX=1952&sizeY=1952&sizeZ=73&sizeC=4&pixelType=int16.fake which is included in https://merge-ci.openmicroscopy.org/web/figure/file/3901/

@pwalczysko
Copy link
Member

Tested on merge-ci

  • without this fix, the slider on the max side is vanishing when slided to the left, and the max value is wrongly formatted
  • with this fix, the slider is working fine and the max value is as expected.

lgtm

@will-moore will-moore merged commit f8b3e4c into ome:master May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants