Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't swap width/height when cropping page #541

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Don't swap width/height when cropping page #541

merged 1 commit into from
Feb 16, 2024

Conversation

will-moore
Copy link
Member

Fixes #539

To test:

  • In page layout, choose "horizontal" page orientation
  • Arrange some panels in a non-square layout (so you can tell the difference between width and height)
  • Now in page layout again, choose "crop" to panels
  • Cropped page should match the panels (not swap width/height as in bug on issue above)

This was referenced Jan 25, 2024
Open
Closed
@will-moore will-moore added this to the 6.2.0 milestone Feb 15, 2024
@pwalczysko
Copy link
Member

tested on ome-training-3 (without this PR) and merge-ci (with this PR).

without this PR, the problem manifests
Screenshot 2024-02-16 at 16 57 36

with this PR, the problem is gone
Screenshot 2024-02-16 at 16 57 28

@will-moore will-moore merged commit 74379f7 into ome:master Feb 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwalczysko pwalczysko pwalczysko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

Crop fails if page/panel is in horizontal orientation
2 participants
@will-moore @pwalczysko