Edit id z stack #518
Merged
Edit id z stack #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2023
Use same logic for theZ and theT for setId()
will-moore
approved these changes
Oct 17, 2023
will-moore
reviewed
Oct 19, 2023
| 'pixel_size_x_unit': data.pixel_size.unitX, | ||
| 'pixel_size_z_unit':data.pixel_size.unitZ, | ||
| 'pixel_size_x_symbol': data.pixel_size.symbolX, |
There was a problem hiding this comment.
I think we should include pixel_size_z_symbol here too.
If it's missing then the code resorts to using the pixel_size_x_symbol for labels, which is why this works without it, but it would be better to include it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix issues #511 and #512