Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cyan color to drop down menu for LUT (fix #498) #516

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

Rdornier
Copy link
Contributor

@Rdornier Rdornier commented Sep 15, 2023

Adding the choice for Cyan color in the display LUT.
Fixing #498 issue

@will-moore
Copy link
Member

Looks good!

Screenshot 2023-09-20 at 16 00 07

@Rdornier
Copy link
Contributor Author

I just see now that I could also add the cyan color to scalebar / label drop down menus (to be consistent).

@jburel
Copy link
Member

jburel commented Oct 31, 2023

Should more colors options also be added to the scale bar color menu for consistency?

@will-moore
Copy link
Member

@jburel I think it's a bit more work to add the "More Colors..." option to scalebar, as you need to create and handle the color-picker response.
But @Rdornier might want to add the Cyan option to scalebar and label colour menus?

@jburel
Copy link
Member

jburel commented Nov 2, 2023

@will-moore Cyan has already been added and it works
so let's keep it like this

@will-moore
Copy link
Member

Sorry, yes I missed that (was looking after the comment at #516 (comment)). So I think this is good to merge then 👍

@will-moore will-moore added this to the 6.1.0 milestone Nov 2, 2023
@will-moore will-moore merged commit b7e85c3 into ome:master Nov 14, 2023
1 check passed
@Rdornier Rdornier deleted the add-cyan-color branch June 13, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants