Default figure filename to YYYY-MM-DD_hh-mm-ss #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-moore
reviewed
Feb 8, 2023
src/js/models/figure_model.js
Outdated
| @@ -550,9 +550,14 @@ | |||
| }, | |||
|
|
|||
| getDefaultFigureName: function() { | |||
| const padL = (nr, len = 2, chr = `0`) => `${nr}`.padStart(2, chr); | |||
There was a problem hiding this comment.
len argument isn't used in padStart(), but you only ever use the first argument anyway, so you could remove the len and chr args?
There was a problem hiding this comment.
Sorry for that, corrected in the last commit
|
Issues closed, thx. If you include e.g. "Fixes #314" in your PRs, that should auto-close the issue when the PR is merged. |
|
Thanks for the tip about auto close issues, will add the right keyword from now on. |
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Will,
tiny PR to replace
:by-for the default figure filename, to solve #314That also includes the padding of date and time with zeros
If you would rather keep the
:, I can revert to that format but keep the padding (otherwise reject the PR :D).Side note, could you also close those solved issues:
Best,
Tom