Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh pages reorganisation #399

Merged
merged 9 commits into from
Aug 21, 2020
Merged

Conversation

jburel
Copy link
Member

@jburel jburel commented Aug 20, 2020

For background #398
This PR:

  • re-organises the files and move them under docs so we can publish without cluttering the master branch
  • adds the redirect plugin
  • redirects figure.o.org to https://www.openmicroscopy.org/omero/figure/
  • blog posts have been either redirected to the announcements on www.o.org or to the GH file in its final location i.e. master/docs
  • removes demo code as agreed with @will-moore
  • redirects figure.o.org/demo. This link will need to be updated when the system in Dundee is back.

To test locally go in the docs folder and run docker run -it --rm -p 4000:4000 -v $PWD:/srv/jekyll jekyll/builder:pages jekyll server -w

docs/_site will be added to .gitignore when migrated to master to avoid conflict

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes proposed her make sense to me and belong to three categories:

  • file removal incl. .gitignore and the content of demo/
  • file renaming and addition of redirect_to markup for the html files
  • file renaming without modification for the remaining files

Most of the proposed redirects looked legit to me although I'll leave @will-moore to sign-off on these changes.

@sbesson sbesson requested a review from will-moore August 20, 2020 20:12
@jburel
Copy link
Member Author

jburel commented Aug 21, 2020

404 is expected until some of the md files are in master

@will-moore
Copy link
Member

Good to merge 👍

@jburel jburel merged commit ab4fe84 into ome:gh-pages Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants