Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure json docs #391

Merged
merged 8 commits into from
May 25, 2020
Merged

figure json docs #391

merged 8 commits into from
May 25, 2020

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented May 18, 2020

Adding a figure file JSON spec to help users with creating files.

View at https://github.com/will-moore/figure/blob/figure_json_docs/docs/figure_file_format.rst

docs/figure_file_format.rst Outdated Show resolved Hide resolved
docs/figure_file_format.rst Outdated Show resolved Hide resolved
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

docs/figure_file_format.rst Outdated Show resolved Hide resolved
docs/figure_file_format.rst Outdated Show resolved Hide resolved
docs/figure_file_format.rst Show resolved Hide resolved
docs/figure_file_format.rst Show resolved Hide resolved
docs/figure_file_format.rst Outdated Show resolved Hide resolved
will-moore and others added 4 commits May 19, 2020 12:18
Co-authored-by: Mark Carroll <m.t.b.carroll@dundee.ac.uk>
Co-authored-by: Mark Carroll <m.t.b.carroll@dundee.ac.uk>
@will-moore will-moore changed the title Initial commit of docs/figure_file_format.rst figure json docs May 21, 2020
docs/figure_file_format.rst Outdated Show resolved Hide resolved
docs/figure_file_format.rst Outdated Show resolved Hide resolved
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Individual elements may need further specification, but that can certainly come with time.

docs/figure_file_format.rst Outdated Show resolved Hide resolved
@jburel
Copy link
Member

jburel commented May 25, 2020

Looks good
Merging so the link can be fixed in the guide PR

@jburel jburel merged commit 45b201a into ome:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants