Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix channel label mismatch #377

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Conversation

will-moore
Copy link
Member

If multiple images with same number of channels are selected, the channel buttons previously showed "undefined" if the labels didn't match.
Now we show no text.

Fixes #364.

Before:
Screenshot 2020-04-18 at 06 51 42

After:
Screenshot 2020-04-18 at 06 51 09

@will-moore will-moore changed the title don't show 'undefined' if channel names mismatch fix channel label mismatch Apr 18, 2020
@jburel
Copy link
Member

jburel commented Apr 18, 2020

The blank button should be shown if the name of the channel does not match
if for example we have 2 images with both DAPI then DAPI should be used instead of a blank button

@will-moore
Copy link
Member Author

That should be how it's working already?

e.g. 2 image selected - First channel is named differently but the other channels have same name in both images:
Screenshot 2020-04-18 at 21 32 22

@jburel
Copy link
Member

jburel commented Apr 18, 2020

I thought so, I was a bit confused by the description in the PR

@jburel
Copy link
Member

jburel commented Apr 22, 2020

Screenshot 2020-04-22 at 13 25 45

@jburel
Copy link
Member

jburel commented Apr 22, 2020

Screenshot 2020-04-22 at 13 29 16

@jburel
Copy link
Member

jburel commented Apr 22, 2020

Looks good

@jburel jburel merged commit 7c8fa8d into ome:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channel name undefined
2 participants