Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Save Figure with no panels #363

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Conversation

will-moore
Copy link
Member

Fixes #336

To test:

  • Create a new figure (e.g. with a single image)
  • Delete all panels so you have a blank page
  • Save -> Choose a name -> OK
  • Figure should get created. Can see it in File > Open etc.
  • Can Open the file and add images later etc....

@joshmoore
Copy link
Member

The change itself looks simple enough; 👍 for merging.

I'd like to point out though that there's some overlap in the if-statements just above and below e.g. a check for if first_img_id is not None: on 249. Glancing over more of the code, I then saw an "upload file" duplicated on line 286. Similar to @jburel's recent ome/training-scripts#80, I think we will need to start taking the opportunities of these simple fixes to also reduce overall code complexity. This change doesn't make it much harder to read, but in the sum, someone would need to think a bit longer the next time they come back to this section.

@pwalczysko
Copy link
Member

OMERO.figure does not seem to work on merge-ci

@will-moore
Copy link
Member Author

Figure on merge-ci was temporarily broken by 'Figure CLI' PR. Working now.

@pwalczysko
Copy link
Member

Works as expected on merge-ci. Ready to merge fmpov

@jburel jburel merged commit a86d41a into ome:master Feb 21, 2020
@will-moore will-moore deleted the no_panels_save_fix branch February 26, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: findByQuery returns multiple
4 participants