Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stroke width paste rect fix #342

Merged
merged 3 commits into from
Jan 9, 2020

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Oct 15, 2019

See #341

Fixes Figure export with Rectangles created from copy of crop region and paste to create Rectangle.
Previously shapes were created with "lineWidth" attribute instead of "strokeWidth".
This is fixed, and we also update previously created files when they are opened.
Workflow described in https://forum.image.sc/t/tips-tricks-gifs-from-uca-embrc-france-omero-database/32268

To test:

  • Copy crop region from one panel
  • Paste it as a new ROI on another panel (creates a Rectangle ROI)
  • Export figure

@pwalczysko
Copy link
Member

Failed travis

@joshmoore
Copy link
Member

Failure will hopefully be fixed by re-running once ome/omero-test-infra#43 is merged.

@joshmoore
Copy link
Member

Removed my temporary VERBOSE="set -x" commit from .travis.yml. With a few pushes to origin/master, omero-test-infra is now passing again.

@jburel
Copy link
Member

jburel commented Jan 8, 2020

Not possible to export from py3-ci/web

@will-moore
Copy link
Member Author

Just uploaded the merged script to py3-ci

@pwalczysko
Copy link
Member

works as expected.

Ready to merge fmpov

@joshmoore joshmoore merged commit cf67c94 into ome:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants