Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export to omero description #329

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Apr 17, 2019

This improves the description of OMERO images created from figure export.
The image description now include references to the images that are contained in the figure (same as the PDF info page does for other forms of figure export).
This helps keep track of where an image-of-a-figure comes from.

To test:

  • export a Figure to OMERO Image
  • check the description for listing the images in the figure
  • In Insight, the Image ID: 123 should be rendered as a clickable link.

In Insight these will link to the images
@jburel
Copy link
Member

jburel commented Apr 24, 2019

  • Image's ID and name are displayed.
  • The UI could quickly become very clutter.
    So maybe we should display the ID only and name in the tooltip.
    Best will be to be able to open the image in iviewer from the ID

Note that insight link is no longer active.

@will-moore
Copy link
Member Author

Unfortunately we don't have the ability to use tooltips etc in the description and if we try to truncate the image name then info will be lost and you could end up with ambiguous names.
I think it's better to keep the full name and risk a little clutter than to remove names.

Screen Shot 2019-07-16 at 12 17 15

@will-moore
Copy link
Member Author

You can also improve the readability in the screenshot above by resizing the right panel so that image names don't wrap onto a second line.

@jburel
Copy link
Member

jburel commented Jul 16, 2019

Looking at the screenshot I am wondering if we should now have
Under Contains Images a list of hyperlinks to the images similar to the link to the figure

@will-moore
Copy link
Member Author

I tried manually editing the description above to see how this looks with links. I tried adding links after the Image ID: 111 for the first few images, and instead of it for the last few images:

Screen Shot 2019-07-17 at 23 45 11

Not sure if we want all this?
Best would be to have Image ID: 111 be rendered as a link, so maybe we should go for this feature and not add other links that will then be redundant.

@jburel
Copy link
Member

jburel commented Jul 18, 2019

Having Image ID rendered as link is the best option.
It has been turned off in insight (I cannot remember why)

@will-moore
Copy link
Member Author

OK, so I'll leave it as it is for now with - Image ID: 123 name.

@jburel
Copy link
Member

jburel commented Jul 18, 2019

How long will it take to render the ID as link?

@will-moore
Copy link
Member Author

Done ome/openmicroscopy#6087

Screen Shot 2019-07-18 at 22 59 44

@jburel
Copy link
Member

jburel commented Aug 30, 2019

Not possible to test the export option on merge-ci, the control is greyed out: script is not installed

@jburel
Copy link
Member

jburel commented Aug 30, 2019

Retested again
It works as expected

@jburel jburel merged commit 506aea4 into ome:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants