Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown buttons on Windows #301

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

will-moore
Copy link
Member

@mtbc
Copy link
Member

mtbc commented Jul 5, 2018

If it does fix it we can then comment on the forum thread accordingly. 👍 for the explanatory comment.

@jburel jburel added this to the 4.0.1 milestone Jul 25, 2018
@jburel
Copy link
Member

jburel commented Jul 26, 2018

I have tested latest and merge with Firefox, Chrome and IE on Windows
and I do not see any difference
I might be missing something.

@jburel jburel removed this from the 4.0.1 milestone Jul 26, 2018
@jburel
Copy link
Member

jburel commented Aug 8, 2018

@will-moore discovered that to reproduce the error you need to enable Touch Screen
This was tested today with a laptop allowing Touch Screen and the changes work now with Touch Screen enabled

@jburel jburel merged commit a2ff92b into ome:master Aug 8, 2018
@will-moore
Copy link
Member Author

Tested on the Windows machine where I reproduced this earlier and it is fixed with this PR.

NB: I also realised that this bug is due to touch-screen functionality which is why we only see it on some machines. When touch-screen is disabled then we don't see the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants