Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T-index label #276

Merged
merged 2 commits into from
Apr 25, 2018
Merged

T-index label #276

merged 2 commits into from
Apr 25, 2018

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Apr 5, 2018

See https://trello.com/c/cVYdrcXM/131-no-time-stamp-use-t-index-instead
Adds support for labels showing T-index.
Useful if the image doesn't have timestamp metadata.

To test:

  • Add Timelapse images to figure, with and without Time-stamp metadata.
  • Choose to create label from Time (index) option (NB: this option will not be disabled in image with no timestamp metadata)
  • Label should show the current T-index for the panel
  • Export of the figure should also show correct T-index label for both images.

@jburel jburel added this to the 4.0.0 milestone Apr 6, 2018
@jburel
Copy link
Member

jburel commented Apr 6, 2018

The manipulation of label needs to be reviewed
if for example as add a label from Time (index), in the edit row, I have to manually change the type.
If I click add, a "second" entry is displayed above the first one
This is confusing

@will-moore
Copy link
Member Author

@jburel Not sure I understand your workflow above. This PR doesn't change the existing workflow, it just adds another option.

@jburel
Copy link
Member

jburel commented Apr 18, 2018

I understand the change made in this PR
but I think we should review the current implementation

@jburel
Copy link
Member

jburel commented Apr 25, 2018

Improvement recorded on the testing sheet.
This can be done in a follow-up PR

@jburel jburel merged commit 26bea38 into ome:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants