Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libraries clean up #223

Merged
merged 6 commits into from
Jun 23, 2017
Merged

libraries clean up #223

merged 6 commits into from
Jun 23, 2017

Conversation

jburel
Copy link
Member

@jburel jburel commented Jun 21, 2017

Remove libraries no longer required

cc @will-moore

@jburel jburel mentioned this pull request Jun 21, 2017
<script src="{% static 'figure/3rdparty/mousetrap-1.5.3/mousetrap.min.js' %}"></script>
<script src="{% static 'figure/3rdparty/backbone.mousetrap/backbone.mousetrap.js' %}"></script>
<script src="{% static 'figure/3rdparty/bootstrap3/js/bootstrap.js' %}"></script>
<script src="{% static 'figure/3rdparty/bootstrap-3.0.0/js/bootstrap.js' %}"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the same bootstrap-3.0.0 rename on the bootstrap css (at top of the page) so the app looks kinda broken now.

@jburel
Copy link
Member Author

jburel commented Jun 22, 2017

@will-moore should look better now

@will-moore
Copy link
Member

Looks good now.

@jburel jburel merged commit 2779ac7 into ome:master Jun 23, 2017
@jburel jburel added this to the 3.1.0 milestone Jun 28, 2017
@jburel jburel deleted the libraries-cleanup branch August 20, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants