-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse intensity #219
Reverse intensity #219
Conversation
Not functional yet - Just moved html and css
I have been trying this to gain space for the flip button, so thank you. Maybe rename |
Conflicting PR. Removed from build FIGURE-merge#465. See the console output for more details.
|
Conflicting PR. Removed from build FIGURE-merge#466. See the console output for more details.
|
Conflicting PR. Removed from build FIGURE-merge#467. See the console output for more details.
|
There's an issue if the image is on a server that does not support Also, most programs call this invert instead of revert. ImageJ, Icy, For what is worth, the colours on the slider do not show up at all on |
cc @waxenegger for name suggestion. FYI @carandraug: omero does not run on debian 9 https://www.openmicroscopy.org/community/viewtopic.php?f=5&t=8295 |
@carandraug We really only support install of latest OMERO.figure on 5.3.x (the message you saw above was added before we made that decision) and the loading of images from other servers is still mostly a demo feature. It would be quite a bit more work to handle the UI for e.g. selecting multiple images, some have reverseInstensity: True, some False and some not-supported, but I'll bear it in mind if we want to improve the handling of external images in future. |
Suggested name adjustment added to https://trello.com/c/AN7eXyM3/19-rename-in-viewer-reverse-intensity |
It is not really obvious that we need to click on "Reverse Intensity" so it can take effect |
The option is now tagging into account in the script |
That's better with the checkbox |
This adds support for Reverse intensity to figure - see https://trello.com/c/11hiGrmx/13-reverse-intensity-codomain
We also update the
luts_10.png
with the Janelia LUTs. NB: this is still hard-coded since changing that is more work and will mean that OMERO.figure will rely on ome/openmicroscopy#5318 (OMERO 5.3.3 at least).Can do this in a future PR/release.
This also moves the channel-toggle buttons down beside the sliders, to align OMERO.figure with our other clients. This frees up more space for other buttons beside the image, such as 'flip'. cc @carandraug.
Includes a fix for toggling channels bug: https://trello.com/c/yWFPR9MJ/160-bug-toggle-channels
To test: