-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xywh panel #169
Xywh panel #169
Conversation
} | ||
else { | ||
console.log(attr); | ||
console.log(value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The console.log
s are probably not necessary, are they?
Looks good from my point of view... Functionality works like expected. |
Only the I think x, y, width & height need to be "number" inputs. |
var this_json = m.toJSON(); | ||
// Format floating point values | ||
_.each(["x", "y", "width", "height"], function(a){ | ||
if (this_json[a] != "-") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed you can remove this if
check now, since m.toJSON()
won't give you any -
values.
Need to fix the setting of minus values for x & y when not on page 1 (seems to always jump to the previous page). |
Working nicely now. No console errors, re-render bug fixed. |
Testing instructions :
Check if the changes get updated on the panels.
@will-moore