-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import from json #162
Import from json #162
Conversation
This looks great and works nicely. I wonder if you could avoid the code duplication by calling the new Cheers! |
d0f6824
to
4112fc2
Compare
4112fc2
to
e36d0f5
Compare
|
||
|
||
load_from_JSON: function(data) { | ||
self = this; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a var
:
var self = this;
Also it would be great to keep all indents at 4 spaces so we are consistent everywhere.
Thanks! Looks great. Tested locally. |
@@ -104,7 +110,7 @@ | |||
|
|||
return json; | |||
}, | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dominikl I wonder if you could remove this whitespace change (and see if there are any others that could be cleaned up)?
I don't know if you're using $ git add -p
but I find this can help avoiding unnecessary whitespace changes?
Thanks
cbc8114
to
c2642eb
Compare
c2642eb
to
ce50557
Compare
Adds the possibility to create a Figure from a (previously exported) JSON object, see Trello - import Figure from json.
I'm not sure, if that's the correct way to add stuff to models, views, etc. please correct me, if not. Especially listening on the form submit within
figure_view.js
seems to be a bit out of place.