Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file filter #147

Merged
merged 3 commits into from
Apr 14, 2016
Merged

Improve file filter #147

merged 3 commits into from
Apr 14, 2016

Conversation

will-moore
Copy link
Member

This improves the filtering of figure files in the File > Open dialog as discussed at #146.

To test:

  • Open the File > Open dialog
  • Try filtering the files with multiple words as discussed in RFE: improved search for figures #146
  • Files should appear in the filtered list if all search words are found in the figure name, regardless of order - splitting words on white-space.

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build FIGURE-merge#125. See the console output for more details.
Possible conflicts:

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build FIGURE-merge#126. See the console output for more details.
Possible conflicts:

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build FIGURE-merge#127. See the console output for more details.
Possible conflicts:

@will-moore will-moore mentioned this pull request Apr 10, 2016
@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build FIGURE-merge#128. See the console output for more details.
Possible conflicts:

@pwalczysko
Copy link
Member

Works as expected. Tested with the example delivered by the external user in #146. Ready to mrege.

@jburel
Copy link
Member

jburel commented Apr 14, 2016

Will be possible to create a common method instead of having the same code twice?

@will-moore
Copy link
Member Author

You're seeing the code changes twice because the concatenated js file is also committed.

@jburel
Copy link
Member

jburel commented Apr 14, 2016

I see. Missed that

@jburel jburel merged commit 6f8a598 into ome:master Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants