Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Img data pixel sizes units #144

Merged
merged 3 commits into from
Apr 1, 2016
Merged

Conversation

will-moore
Copy link
Member

This is a continuation of discussion at #142 (since that branch was incorrectly named and then deleted).

Latest commit now adds additional valueX and valueY attributes to the imgData json instead of overwriting existing pixel_size x and y. So now the json looks like

pixel_size: {
    symbolX: "mm",
    unitY: "MILLIMETER",
    unitX: "MILLIMETER",
    y: 9800,
    x: 9800,
    symbolY: "mm",
    z: 9800,
    valueY: 9.8,
    valueX: 9.8
},

cc @chris-allan.

@chris-allan
Copy link
Member

Looks great from a technical perspective. Will let someone else comment on how things are working in the user interface.

@pwalczysko
Copy link
Member

Did analogical comparisons as described in #142 (comment), except that left out the Insight part. All looks good between webclient and Figure for real images in nm, dm, mm.
All good here by me.

@jburel jburel merged commit e8ce6d7 into ome:master Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants