Fix rotation of vertical labels with pillow 3.1.0 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2016
|
If we bump the version of pillow, we will need to release a new version of figure. |
| @@ -1587,7 +1587,7 @@ def drawText(self, text, x, y, fontsize, rgb, align="center"): | |||
| tempLabel = Image.new('RGBA', (txt_w, txt_h), (255, 255, 255, 0)) | |||
| textdraw = ImageDraw.Draw(tempLabel) | |||
| textdraw.text((0, 0), text, font=font, fill=rgb) | |||
| w = tempLabel.rotate(90) | |||
| w = tempLabel.rotate(90, expand=True) | |||
There was a problem hiding this comment.
Does this change also work with 2.9 or just 3.1?
There was a problem hiding this comment.
It works with 2.9 too. The API is the same, it seems that it's just the default behaviour that changed.
|
tested with Pillow 2.9 and Pillow 3.1 |
|
@will-moore: can we discuss the branching strategy of this repo before merging this PR? |
|
@will-moore: sorry I thought I merged it following our discussion on branches the other day |
jburel
added a commit
that referenced
this pull request
Feb 4, 2016
Fix rotation of vertical labels with pillow 3.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the rotation of vertical labels when exporting as Tiff.
Noticed when testing Pillow 3.1.0 (not a problem on Pillow 2.9.0) See ome/omero-install#86
To test, create a figure with vertical labels and export as Tiff using Pillow 3.1.0 (latest version).
Check vertical labels are in correct position.