Write version attribute to image-label specification #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fmt parameter to write_label_metadata signature Add logic to store the format version in the image-label attributes Updates the label writing tests to test the version metadata
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 83.85% 83.86% +0.01%
==========================================
Files 12 12
Lines 1375 1376 +1
==========================================
+ Hits 1153 1154 +1
Misses 222 222
Continue to review full report at Codecov.
|
will-moore
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Code looks good, and using the comparison approach @sbesson described at ome/omero-cli-zarr#107, this fixes the loss of version number caused by the change in that PR. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered during the testing of ome/omero-cli-zarr#107
The
write*label*APIs introduced in #178 do not store the OME-NGFF specification version in theimage-labelattributes.The changes proposed in this PR
fmtoptional parameter towrite_label_metadataimage-labelattributesI would be inclined this as a bug fix and would suggest to get it out as a patch release
0.4.3. But strictly speaking, this adds an optional parameter to a public API and could be released as a minor version increment.