Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #65

Closed
wants to merge 1 commit into from
Closed

[pre-commit.ci] pre-commit autoupdate #65

wants to merge 1 commit into from

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Aug 1, 2022 •
edited
Loading

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022 •
edited
Loading

Codecov Report

Base: 92.43% // Head: 92.43% // No change to project coverage 👍

Coverage data is based on head (71de889) compared to base (1105df9).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   92.43%   92.43%           
=======================================
  Files           3        3           
  Lines         185      185           
=======================================
  Hits          171      171           
  Misses         14       14

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@will-moore
Copy link
Member

See globality-corp/flake8-logging-format#35
Looks like there's a fix, but not release yet

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 119a568 to ffd39c8 Compare August 8, 2022 22:23
@sbesson
Copy link
Member

sbesson commented Aug 9, 2022

@will-moore @joshmoore looks like the usage of f-strings and expr % variable within logging statements is discouraged and now reported in the latest version of flake8. A few repositories will need updated, with ome-zarr-py making the biggest usage. d6b48bb proposes the corresponding fixed in the context of this repository. Leaving you to review and I can update the other repositories if we agree.

@sbesson sbesson requested review from joshmoore and will-moore and removed request for joshmoore August 9, 2022 08:45
will-moore
will-moore approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging is still working as before and flake8 is green. 👍

@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
71de889 
updates:
- [github.com/psf/black: 22.6.0 → 22.8.0](psf/black@22.6.0...22.8.0)
- [github.com/asottile/pyupgrade: v2.37.2 → v2.37.3](asottile/pyupgrade@v2.37.2...v2.37.3)
- [github.com/PyCQA/flake8: 4.0.1 → 5.0.4](PyCQA/flake8@4.0.1...5.0.4)
@joshmoore
Copy link
Member

I find it sad that f-strings are apparently a no-no for logging but otherwise 🤷🏽

@joshmoore joshmoore mentioned this pull request Sep 12, 2022
Merged
@joshmoore
Copy link
Member

Closing in favor of gh-68.

@joshmoore joshmoore closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will-moore will-moore will-moore approved these changes

@joshmoore joshmoore Awaiting requested review from joshmoore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecov-commenter @will-moore @sbesson @joshmoore