Remove unnecessary Python script for bumping component versions #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original intent of the script was to simplify the bump of the POM versions as well as the static STABLE_VERSION field in the UpgradeChecker class on release. In the context of the IDR fork of Bio-Formats, additional functionality was added to manage versions for a custom groupId. As the UpgradeChecker.STABLE_VERSION has been deprecated and the IDR fork is no longer active, this script is redundant and can be fully replaced by `mvn versions:set` which is the current documented workflow for Bio-Formats releases.
sbesson
changed the title
|
Generally 👍, but note too https://github.com/search?q=org%3Aopenmicroscopy%20bump_maven_version&type=code and in particular https://github.com/openmicroscopy/management_tools/blob/master/ci/jobs/BIOFORMATS-DEV-latest-version-bump_0001.sh. I don't know what the impact there might be. |
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intent of the script was to simplify the bump of the POM versions as well as the static STABLE_VERSION field in the UpgradeChecker class on release. In the context of the IDR fork of Bio-Formats, additional functionality was added to manage versions for a custom groupId.
As the UpgradeChecker.STABLE_VERSION has been deprecated and the IDR fork is no longer active, this script is redundant and can be fully replaced by
mvn versions:setwhich is the current documented workflow for Bio-Formats releases.https://github.com/search?q=org%3Aome%20bump_maven_version&type=code indicates there are 2 downstream documentation places which refer to this script and which I can update if this PR is approved