Skip to content

Commit

Permalink
Deprecate vtl attributes in data source/resource (IBM-Cloud#5265)
Browse files Browse the repository at this point in the history
* Deprecate vtl argument in pi_catalog_images data source

* Mark deprecated values in instance data source/resource
  • Loading branch information
ismirlia authored Apr 22, 2024
1 parent ddfaf60 commit 28f9e0c
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 4 deletions.
1 change: 1 addition & 0 deletions ibm/service/power/data_source_ibm_pi_catalog_images.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ func DataSourceIBMPICatalogImages() *schema.Resource {
Type: schema.TypeBool,
},
Arg_VTL: {
Deprecated: "This field is deprecated.",
Description: "Set true to include VTL images. The default value is false.",
Optional: true,
Type: schema.TypeBool,
Expand Down
1 change: 1 addition & 0 deletions ibm/service/power/data_source_ibm_pi_instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ func DataSourceIBMPIInstance() *schema.Resource {
},
Attr_LicenseRepositoryCapacity: {
Computed: true,
Deprecated: "This field is deprecated.",
Description: "The VTL license repository capacity TB value.",
Type: schema.TypeInt,
},
Expand Down
1 change: 1 addition & 0 deletions ibm/service/power/data_source_ibm_pi_instances.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ func DataSourceIBMPIInstances() *schema.Resource {
},
Attr_LicenseRepositoryCapacity: {
Computed: true,
Deprecated: "This field is deprecated.",
Description: "The VTL license repository capacity TB value.",
Type: schema.TypeInt,
},
Expand Down
1 change: 1 addition & 0 deletions ibm/service/power/resource_ibm_pi_instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ func ResourceIBMPIInstance() *schema.Resource {
Type: schema.TypeInt,
Optional: true,
Computed: true,
Deprecated: "This field is deprecated.",
Description: "The VTL license repository capacity TB value",
},
"status": {
Expand Down
2 changes: 1 addition & 1 deletion website/docs/d/pi_catalog_images.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Review the argument reference that you can specify for your data source.

- `pi_cloud_instance_id` - (Required, String) The GUID of the service instance associated with an account.
- `sap` - (Optional, Bool) Set `true` to include SAP images. The default value is `false`.
- `vtl` - (Optional, Bool) Set `true` to include VTL images. The default value is `false`.
- `vtl` - (Deprecated, Optional, Bool) Set `true` to include VTL images. The default value is `false`.

## Attribute reference
In addition to the argument reference list, you can access the following attribute references after your data source is created.
Expand Down
2 changes: 1 addition & 1 deletion website/docs/d/pi_instance.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ In addition to all argument reference list, you can access the following attribu
- `ibmi_rds` - (Boolean) IBM i Rational Dev Studio.
- `ibmi_rds_users` - (Integer) IBM i Rational Dev Studio Number of User Licenses.
- `id` - (String) The unique identifier of the instance.
- `license_repository_capacity` - (Integer) The VTL license repository capacity TB value. Only available with VTL instances.
- `license_repository_capacity` - (Deprecated, Integer) The VTL license repository capacity TB value. Only available with VTL instances.
- `maxmem`- (Float) The maximum amount of memory that can be allocated to the instance without shutting down or rebooting the `LPAR`.
- `maxproc`- (Float) The maximum number of processors that can be allocated to the instance without shutting down or rebooting the `LPAR`.
- `max_virtual_cores` - (Integer) The maximum number of virtual cores that can be assigned without rebooting the instance.
Expand Down
2 changes: 1 addition & 1 deletion website/docs/d/pi_instances.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ In addition to all argument reference list, you can access the following attribu

Nested scheme for `pvm_instances`:
- `health_status` - (String) The health of the instance.
- `license_repository_capacity` - The VTL license repository capacity TB value. Only available with VTL instances.
- `license_repository_capacity` - (Deprecated, Integer) The VTL license repository capacity TB value. Only available with VTL instances.
- `memory` - (Float) The amount of memory that is allocated to the instance.
- `minproc`- (Float) The minimum number of processors that must be allocated to the instance.
- `maxproc`- (Float) The maximum number of processors that can be allocated to the instance without shutting down or rebooting the `LPAR`.
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/pi_instance.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Review the argument references that you can specify for your resource.
- **Note**: only images belonging to your project can be used image for deploying a Power Systems Virtual Server instance. To import an images to your project, see [ibm_pi_image](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/pi_image).
- `pi_instance_name` - (Required, String) The name of the Power Systems Virtual Server instance.
- `pi_key_pair_name` - (Optional, String) The name of the SSH key that you want to use to access your Power Systems Virtual Server instance. The SSH key must be uploaded to IBM Cloud.
- `pi_license_repository_capacity` - (Optional, Integer) The VTL license repository capacity TB value. Only use with VTL instances. `pi_memory >= 16 + (2 * pi_license_repository_capacity)`.
- `pi_license_repository_capacity` - (Deprecated, Optional, Integer) The VTL license repository capacity TB value. Only use with VTL instances. `pi_memory >= 16 + (2 * pi_license_repository_capacity)`.
- **Note**: Provisioning VTL instances is temporarily disabled.
- `pi_memory` - (Optional, Float) The amount of memory that you want to assign to your instance in gigabytes.
- Required when not creating SAP instances. Conflicts with `pi_sap_profile_id`.
Expand Down

0 comments on commit 28f9e0c

Please sign in to comment.