Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and some changes items #13

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Bug fixes and some changes items #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p

- Refactor application.

## [0.10.4] - 2021-10-10

### Fixed

- Fix incorrect link location after creation.

## [0.10.3] - 2021-10-07

### Added
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

The Quick Symlink is a `Finder extension` which provides a `contextual menu item` for the symbolic links creation on macOS.

[![status](https://img.shields.io/badge/status-active-active?style=flat-square)](BADGES_GUIDE.md#status) [![version](https://img.shields.io/badge/version-0.10.3-informational?style=flat-square)](BADGES_GUIDE.md#version) [![oss lifecycle](https://img.shields.io/badge/oss_lifecycle-active-important?style=flat-square)](BADGES_GUIDE.md#oss-lifecycle) [![maintenance](https://img.shields.io/badge/maintenance-yes-informational?style=flat-square)](BADGES_GUIDE.md#maintenance) [![last release](https://img.shields.io/badge/last_release-October_05,_2021-informational?style=flat-square)](BADGES_GUIDE.md#release-date) [![last commit](https://img.shields.io/badge/last_commit-October_07,_2021-informational?style=flat-square)](BADGES_GUIDE.md#commit-date)
[![status](https://img.shields.io/badge/status-active-active?style=flat-square)](BADGES_GUIDE.md#status) [![version](https://img.shields.io/badge/version-0.10.4-informational?style=flat-square)](BADGES_GUIDE.md#version) [![oss lifecycle](https://img.shields.io/badge/oss_lifecycle-active-important?style=flat-square)](BADGES_GUIDE.md#oss-lifecycle) [![maintenance](https://img.shields.io/badge/maintenance-yes-informational?style=flat-square)](BADGES_GUIDE.md#maintenance) [![last release](https://img.shields.io/badge/last_release-October_10,_2021-informational?style=flat-square)](BADGES_GUIDE.md#release-date) [![last commit](https://img.shields.io/badge/last_commit-October_10,_2021-informational?style=flat-square)](BADGES_GUIDE.md#commit-date)

[![license](https://img.shields.io/badge/license-MIT-informational?style=flat-square)](LICENSE) [![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-v2.0%20adopted-ff69b4.svg?style=flat-square)](CODE_OF_CONDUCT.md)

Expand Down
1 change: 1 addition & 0 deletions commons/link/action/CopyPathAction.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public class CopyPathAction: QuickSymlinkAction {
paths.append(contentsOf: path.relativePath);
paths.append(";");
}

if (!paths.isEmpty) {
paths.removeLast();
}
Expand Down
12 changes: 5 additions & 7 deletions commons/link/action/CreateLinkAction.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,18 @@ public class CreateLinkAction: QuickSymlinkAction {

public func execute() {
//Get all selected path
guard let target = self.finderController.selectedItemURLs() else {
guard var target = self.finderController.selectedItemURLs() else {
NSLog("FinderSync() failed to obtain targeted URLs: %@");

return;
}

for path in target {
let targetPath = self.fileLinkManager.getTargetPath(path, to: path.deletingLastPathComponent());
self.fileLinkManager.linkWith(of: path, with: targetPath);
if (target.isEmpty) {
target.append(self.finderController.targetedURL()!);
}

if (target.isEmpty) {
let path = self.finderController.targetedURL()!;
let targetPath = self.fileLinkManager.getTargetPath(path, to: path);
for path in target {
let targetPath = self.fileLinkManager.getTargetPath(path, to: path == self.finderController.targetedURL()! ? path : path.deletingLastPathComponent());
self.fileLinkManager.linkWith(of: path, with: targetPath);
}
}
Expand Down
2 changes: 1 addition & 1 deletion hard-link-actions-extension/FinderSync.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class FinderSync: FIFinderSync {
let finderSync = FIFinderSyncController.default();

// Shared group preferences required
_ = UserDefaults.init(suiteName: "org.ololx.quick-symlink")
//_ = UserDefaults.init(suiteName: "org.ololx.QuickSymlink")

if let mountedVolumes = FileManager.default.mountedVolumeURLs(includingResourceValuesForKeys: nil,
options: .skipHiddenVolumes) {
Expand Down
2 changes: 1 addition & 1 deletion soft-link-actions-extension/FinderSync.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class FinderSync: FIFinderSync {
let finderSync = FIFinderSyncController.default();

// Shared group preferences required
_ = UserDefaults.init(suiteName: "org.ololx.quick-symlink")
//_ = UserDefaults.init(suiteName: "org.ololx.QuickSymlink")

if let mountedVolumes = FileManager.default.mountedVolumeURLs(includingResourceValuesForKeys: nil,
options: .skipHiddenVolumes) {
Expand Down