Retry function does not take params; should be bool (#36)

oliver006 · Dec 13, 2023 · 0e21e20 · 0e21e20
1 parent 652c0fe
commit 0e21e20
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/main.go b/main.go
@@ -25,7 +25,7 @@ type Function struct {
 	EntryPoint           string `json:"entrypoint"`
 	Memory               string `json:"memory"`
 	Region               string `json:"region"`
-	Retry                string `json:"retry"`
+	Retry                bool   `json:"retry"`
 	Runtime              string `json:"runtime"`
 	Source               string `json:"source"`
 	Timeout              string `json:"timeout"`
@@ -354,8 +354,8 @@ func CreateExecutionPlan(cfg *Config) (Plan, error) {
 			if f.Region != "" {
 				args = append(args, "--region", f.Region)
 			}
-			if f.Retry != "" {
-				args = append(args, "--retry", f.Retry)
+			if f.Retry {
+				args = append(args, "--retry")
 			}
 			if f.Timeout != "" {
 				args = append(args, "--timeout", f.Timeout)

diff --git a/main_test.go b/main_test.go
@@ -268,7 +268,7 @@ func TestExecutePlan(t *testing.T) {
 						TriggerResource: "gs://bucket/files/cool",
 						Source:          "src/",
 						Region:          "us-east1",
-						Retry:           "3",
+						Retry:           true,
 					},
 					{
 						Name:            "ProcessMoreEvents",
@@ -293,7 +293,7 @@ func TestExecutePlan(t *testing.T) {
 				{"--quiet", "functions", "deploy", "--project", pId, "--verbosity", "info", "ProcessEvents", "--runtime", "go111", "--trigger-http", "--allow-unauthenticated", "--memory", "512MB", "--timeout", "20s"},
 				{"--quiet", "functions", "deploy", "--project", pId, "--verbosity", "info", "ProcessEvents", "--runtime", "go111", "--trigger-http", "--gen2", "--memory", "512MB", "--timeout", "20s"},
 				{"--quiet", "functions", "deploy", "--project", pId, "--verbosity", "info", "ProcessPubSub", "--runtime", "python37", "--trigger-topic", "topic/emails/filtered", "--memory", "2048MB", "--timeout", "20s"},
-				{"--quiet", "functions", "deploy", "--project", pId, "--verbosity", "info", "ProcessNews", "--runtime", "go111", "--trigger-bucket", "gs://bucket/files/cool", "--source", "src/", "--region", "us-east1", "--retry", "3"},
+				{"--quiet", "functions", "deploy", "--project", pId, "--verbosity", "info", "ProcessNews", "--runtime", "go111", "--trigger-bucket", "gs://bucket/files/cool", "--source", "src/", "--region", "us-east1", "--retry"},
 				{"--quiet", "functions", "deploy", "--project", pId, "--verbosity", "info", "ProcessMoreEvents", "--runtime", "go111", "--trigger-event", "my.event", "--trigger-resource=my.trigger.resource", "--entry-point", "FuncEntryPoint"},
 				{"--quiet", "functions", "deploy", "--project", pId, "--verbosity", "info", "ProcessEventsWithDifferentSA", "--runtime", "nodejs10", "--trigger-http", "--memory", "512MB", "--timeout", "20s", "--service-account", "account@project.iam.gserviceaccount.com"},
 			},